Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for deeply nested causes #192

Merged
merged 1 commit into from
May 23, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 23, 2024

Amends #176 to work with my latest Jakarta prototype, which wraps the javax.servlet.ServletException in one layer of jakarta.servlet.ServletException as part of the compatibility code. Rather than attempt to peel back the layers with more null checks, I am simply using a Guava method to get the deepest exception.

Testing done

mvn clean verify now passes on both the default branch and my Jakarta prototype

@basil basil requested a review from a team as a code owner May 23, 2024 18:18
@jglick jglick merged commit 4bcc83e into jenkinsci:master May 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants