Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad short parameter names before using File.createTempFile #14

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Pad short parameter names before using File.createTempFile #14

merged 2 commits into from
Jan 30, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 30, 2021

Otherwise can get an error:

Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to remote
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1800)
		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
		at hudson.remoting.Channel.call(Channel.java:1001)
		at hudson.FilePath.act(FilePath.java:1070)
		at hudson.FilePath.act(FilePath.java:1059)
		at hudson.FilePath.createTempFile(FilePath.java:1419)
		at io.jenkins.plugins.file_parameters.AbstractFileParameterValue.createTempFile(AbstractFileParameterValue.java:75)
		at io.jenkins.plugins.file_parameters.FileParameterWrapper.setUp(FileParameterWrapper.java:89)
		at org.jenkinsci.plugins.workflow.steps.CoreWrapperStep$Execution2.doStart(CoreWrapperStep.java:116)
		at org.jenkinsci.plugins.workflow.steps.GeneralNonBlockingStepExecution.lambda$run$0(GeneralNonBlockingStepExecution.java:77)
		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
java.lang.IllegalArgumentException: Prefix string too short
	at java.io.File.createTempFile(File.java:2003)
	at hudson.FilePath$CreateTempFile.invoke(FilePath.java:1434)
	at hudson.FilePath$CreateTempFile.invoke(FilePath.java:1424)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3122)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:375)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:73)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@jglick jglick requested a review from a team as a code owner January 30, 2021 22:49
@jglick jglick added the bug Something isn't working label Jan 30, 2021
@jglick jglick enabled auto-merge January 30, 2021 22:49
@jglick jglick disabled auto-merge January 30, 2021 23:07
@jglick jglick merged commit 0ae16ce into jenkinsci:master Jan 30, 2021
@jglick jglick deleted the shortParameterName branch January 30, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant