Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Split examples into separate snippets #121

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

jsokol805
Copy link

I found it quite suprising that one single snippet was in fact two examples in one
field - I think splitting them up is a bit more readable.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jsokol805 jsokol805 requested a review from a team as a code owner August 3, 2022 10:30
@jglick jglick added the documentation Improvements or additions to documentation label Aug 3, 2022
README.md Outdated Show resolved Hide resolved
@jsokol805 jsokol805 force-pushed the jsokol/update-docs/1 branch 2 times, most recently from a9dedbe to ba7740b Compare August 3, 2022 15:09
@jglick
Copy link
Member

jglick commented Aug 3, 2022

Needs the merge conflict with #122 resolved.

I found it quite suprising that one single snippet was in fact two examples in one
field - I think splitting them up is a bit more readable.
@jsokol805 jsokol805 force-pushed the jsokol/update-docs/1 branch from ba7740b to 7841600 Compare August 3, 2022 15:18
@jsokol805
Copy link
Author

Merge conflict resolved ;-)

@jglick jglick merged commit 9a4bfdb into jenkinsci:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants