Add support for parsing build result from string #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins » external-monitor-job-plugin #4 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Not currently mergeable. Use |
|
Uhm, the change is an useful enhancement, which seems to be relevant even in the current code. Makes sense to revisit and merge it |
Previously only numeric process return values were supported in XML result-tag. This change adds support for parsing string results. Biggest advantage is that this allows setting any build result supported by hudson.model.Result and not only success or failure. For backward compatibility parsing a numeric return value is always attempted first.
jglick
approved these changes
Jan 21, 2022
Comment on lines
+91
to
+92
| Scanner sc = new Scanner(text); | ||
| if (sc.hasNextInt()) { |
There was a problem hiding this comment.
Probably better to use Integer.parseInt + catch (NumberFormatException but OK.
|
Nine years late, but this is now shipped. |
|
Note that this did not update the CLI command—only the REST flavor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only numeric process return values were supported in
XML result-tag. This change adds support for parsing string
results. Biggest advantage is that this allows setting any build
result supported by hudson.model.Result and not only success or
failure. For backward compatibility parsing a numeric return value
is always attempted first.