Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PNG icons with shields.io-style SVG icons #8

Merged
merged 3 commits into from
Jun 23, 2014

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented May 16, 2014

@cloudbees-pull-request-builder

plugins » embeddable-build-status-plugin #13 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

plugins » embeddable-build-status-plugin #14 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

plugins » embeddable-build-status-plugin #15 SUCCESS
This pull request looks good

@mgedmin
Copy link
Member Author

mgedmin commented May 16, 2014

I've manually tested the .hpi built by cloudbees-pull-request-builder. It works:
ekrano nuotrauka i 2014-05-16 12 01 04

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@vladikoff
Copy link

:shipit:

@vladikoff
Copy link

@mgedmin I kind of wish the badge would say jenkins passing, but that's mostly because my project runs both Travis and Jenkins for different purposes.

@suryagaddipati
Copy link
Member

Nice work @mgedmin . LGTM

@mgedmin
Copy link
Member Author

mgedmin commented Jun 2, 2014

I kind of wish the badge text was configurable (I have Windows and Linux builds, in addition to Travis CI, at http://projects.gedmin.as/#maintenance), but that would be a different issue.

@vladikoff
Copy link

@mgedmin how would this get merged?

@mgedmin
Copy link
Member Author

mgedmin commented Jun 23, 2014

I'll ask for the commit bit on the dev mailing list, as per http://jenkins-ci.org/pull-request-greeting

mgedmin added a commit that referenced this pull request Jun 23, 2014
Replace PNG icons with shields.io-style SVG icons
@mgedmin mgedmin merged commit 52569ee into jenkinsci:master Jun 23, 2014
@mgedmin mgedmin deleted the svg-icons branch June 23, 2014 13:44
@jglick
Copy link
Member

jglick commented Aug 18, 2014

@mgedmin are you now maintaining this plugin? If so, do you plan to cut a new release soon? I have been asked about the status of #6 (JENKINS-17028).

@akoeplinger
Copy link

I'd also like to have a release with the caching changes.

Additionally, the following PRs make basically the same changes as this PR, so they can be closed I think: #3, #7, #9

@mgedmin
Copy link
Member Author

mgedmin commented Sep 3, 2014

I'd also like to have a release :-)

I have the commit bit now. I know nothing about cutting releases. I'd hoped I would find some time/energy to learn and try to do that, but if anyone else can, please don't wait for me!

@akoeplinger
Copy link

@mgedmin a recent release which includes the changes of this PR was done with 50f2a49 and I see it on the Jenkins plugin wiki, so my needs are fulfilled :)

This was referenced Jan 27, 2015
@mgedmin
Copy link
Member Author

mgedmin commented Jan 27, 2015

It would be good to have support for alternative styles (e.g. ?style=flat), as seen on http://shields.io or https://travis-ci.org.

@mgedmin
Copy link
Member Author

mgedmin commented Jan 27, 2015

There's a planned flag day (Feb 1st, 2015) for switching all shields.io-based badges to the flat style by default: badges/shields#185 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants