Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for y-axis zoom in renderConfigurableZoomableTrendChart() #306

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

steve-dwyer-itdev
Copy link
Contributor

Add an optional argument (allowYAxisZoom) to renderConfigurableZoomableTrendChart() to enable y-axis zooming via the dataZoom e-charts option.

Testing done

Verified the chart with, and without the allowYAxisZoom set to true. See screenshots below.
Using the y-axis slider correctly zooms the chart.

allowYAxisZoom = false
image

allowYAxisZoom = true
image

[tasklist]

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #306 (1b415ef) into master (49d89b3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #306   +/-   ##
=========================================
  Coverage     51.42%   51.42%           
  Complexity       17       17           
=========================================
  Files             7        7           
  Lines           105      105           
  Branches          3        3           
=========================================
  Hits             54       54           
  Misses           51       51           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner added the enhancement Enhancement of existing functionality label Sep 26, 2023
@uhafner
Copy link
Member

uhafner commented Sep 29, 2023

Thanks!

@uhafner uhafner merged commit fe2a794 into jenkinsci:master Sep 29, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants