[JENKINS-27260] SPNEGO for Windows in EC2 Plugin #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the Windows temp directory getting set to "" Enabled SPNEGO authentication JENKINS-25385 and JENKINS-4995 both have comments complaining about infinite loops when creating Windows slaves. Because SPNEGO is unregistered for, the httpclient throws and exception that is silently caught and causes the infinite loop.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Jenkins » ec2-plugin #90 SUCCESS |
|
We're using this in production at my workplace and it's working perfectly for Windows AMIs to be spun up. @francisu would you mind taking a look and merging if all seems well? |
francisu
added a commit
that referenced
this pull request
Apr 11, 2015
[JENKINS-27260] SPNEGO for Windows in EC2 Plugin
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Jenkins-27260:
JENKINS-25385 and JENKINS-4995 both have comments complaining about infinite loops when creating Windows slaves. Because SPNEGO is unregistered for, the httpclient throws an exception that is silently
caught and causes the infinite loop.
I was able to connect to WinRM, but I had to re enable SPNEGO. I'm not sure what repercussions that will have otherwise, I'm hoping someone can comment on that.
I also found that the tmpDir was getting set to "", causing a failure, so I added in a case for that.