Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log message from EC2 RunInstances call to include number of nodes requested #1033

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Update log message from EC2 RunInstances call to include number of nodes requested #1033

merged 3 commits into from
Jan 10, 2025

Conversation

sfc-gh-mmansour
Copy link
Contributor

JENKINS-75098

Update log message from EC2 RunInstances call to include number of nodes requested

Testing done

Ran unit test that covers the new code.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@res0nance
Copy link
Contributor

This has a conflict with your previous PR #1032

@sfc-gh-mmansour
Copy link
Contributor Author

This has a conflict with your previous PR #1032

Fixed.

@res0nance res0nance added the enhancement Feature additions or enhancements label Jan 10, 2025
@res0nance res0nance merged commit 5263995 into jenkinsci:master Jan 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res0nance res0nance res0nance approved these changes

Assignees
No one assigned
Labels
enhancement Feature additions or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mmansour @res0nance