Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update constructor to follow CasC best practices" #416

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

vineeth-bandi
Copy link
Collaborator

Reverts #406 as per #411, the latest changes has a hard to reproduce bug and we are unable to identify what's causing it.

@pdk27 pdk27 self-requested a review October 31, 2023 16:42
Copy link
Collaborator

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge after checks have passed 👍

@vineeth-bandi vineeth-bandi merged commit 2b95c2b into master Oct 31, 2023
13 checks passed
@vineeth-bandi vineeth-bandi added the removed PR Label for automated release notes drafter label Nov 1, 2023
@vineeth-bandi vineeth-bandi deleted the revert-406-constructor-best-practices branch November 14, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removed PR Label for automated release notes drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants