clarify Always Reconnect property of EC2 Fleet cloud configurations #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineeth-bandi
force-pushed
the
clarify-always-reconnect
branch
from
ad96bf7 to
1b9767f
Compare
Fixed. |
|
Always Reconnect seems like by default it should be checked. I don't believe it is currently. Thanks so much for the PR, I'll check it now that I understand what it does haha :) |
pdk27
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #349
Clarifying the Always Reconnect property of EC2 Fleet cloud configurations based on #349 on Jenkins UI.
Testing done
Created two cloud configurations with identical attributes outside of Always Reconnect. Verified that Always Reconnect only has unique behavior when Instances on EC2 Fleet reboot. Jenkins restart will always reconnect to EC2 Fleet regardless of whether Always Reconnect is included in configuration. Nodes will stay offline if instance is rebooted and Always Reconnect is not selected.
Submitter checklist