handling issues 347,364 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdk27
requested changes
Jul 12, 2023
pdk27
reviewed
Jul 12, 2023
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| <f:description>Fleet list will be available once region and credentials are specified. Only maintain supported, see help</f:description> | |||
| <f:entry title="${%EC2 Fleet}" field="fleet"> | |||
| <f:select/> | |||
| <f:select checkMethod="post"/> | |||
There was a problem hiding this comment.
is this required? Does it make any difference to the validation? 🤔
There was a problem hiding this comment.
Previously was trying a different implementation, and was getting an error Jenkins: 403 No valid crumb was included in the request, which required making the check method a post request. But, should not need it for the current approach. Thanks, updating
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling following issues
Testing done
Build plugin locally and ran unit tests. Verified changes on local running jenkins server
Verified the default asg when creating/update a ec2 fleet cloud is
please-select.Set default for asg to
please-selectand tried to save. Verified a failure occurs on saving the ec2 fleet cloud configurationCreated two ASGs, configured one for a ec2 fleet cloud, deleted it, and verified that the cloud uses
please-selectas the asg option and not the other ASGTasks