Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logs and help #369

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix logs and help #369

merged 2 commits into from
Jun 1, 2023

Conversation

pdk27
Copy link
Collaborator

@pdk27 pdk27 commented Jun 1, 2023 •
edited
Loading

Changes

  • Add clarity to EC2FleetOnlineChecker logs to replace node name i-0123456789abcdefg with node display name EC2FleetCloud1 i-0123456789abcdefg which includes the cloud name.
  • Add help text to minSpareSize

Testing done

Ran Jenkins with snapshot version of plugin and verified changes.

Before:

[INFO  ][com.amazon.jenkins.ec2fleet.EC2FleetOnlineChecker run] Node 'i-0123456789abcdefg' connected. Resolving planned node

After:

[INFO  ][com.amazon.jenkins.ec2fleet.EC2FleetOnlineChecker run] Node 'EC2FleetCloud1 i-0123456789abcdefg' connected. Resolving planned node

@pdk27 pdk27 requested a review from jillmon June 1, 2023 17:46
@pdk27 pdk27 merged commit 36ed713 into jenkinsci:master Jun 1, 2023
@pdk27 pdk27 deleted the fix-logs-help branch June 1, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillmon jillmon jillmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdk27 @jillmon