Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ARM64 Java in JDK17 Bullseye #310

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Fix ARM64 Java in JDK17 Bullseye #310

merged 10 commits into from
Nov 2, 2022

Conversation

carpnick
Copy link
Contributor

@carpnick carpnick commented Oct 31, 2022 •
edited
Loading

Fixes #308. Use platform dependent image by default to get correct java runtime.

Use native java runtime when on arm32 to get around jmods error:
"jmods: Value too large for defined data type" error

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@carpnick carpnick mentioned this pull request Nov 1, 2022
Closed
@carpnick carpnick changed the title WIP Fix ARM64 Java in JDK17 Bullseye Nov 1, 2022
@carpnick carpnick marked this pull request as ready for review November 1, 2022 13:32
@carpnick carpnick requested a review from a team as a code owner November 1, 2022 13:32
lemeurherve
lemeurherve reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Formatting suggestions only)

17/bullseye/Dockerfile Outdated Show resolved Hide resolved
17/bullseye/Dockerfile Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
17/bullseye/Dockerfile Outdated Show resolved Hide resolved
carpnick and others added 4 commits November 1, 2022 10:26
@carpnick @lemeurherve
Update 17/bullseye/Dockerfile
05215cc 
Co-authored-by: Hervé Le Meur <[email protected]>
@carpnick @lemeurherve
Update 17/bullseye/Dockerfile
f18e392 
Co-authored-by: Hervé Le Meur <[email protected]>
@carpnick @lemeurherve
Update docker-bake.hcl
1596562 
Co-authored-by: Hervé Le Meur <[email protected]>
@carpnick @lemeurherve
Update 17/bullseye/Dockerfile
6c4b6a6 
Co-authored-by: Hervé Le Meur <[email protected]>
gounthar
gounthar reviewed Nov 2, 2022
View reviewed changes
17/bullseye/Dockerfile Outdated Show resolved Hide resolved
gounthar
gounthar reviewed Nov 2, 2022
View reviewed changes
17/bullseye/Dockerfile Outdated Show resolved Hide resolved
gounthar
gounthar reviewed Nov 2, 2022
View reviewed changes
17/bullseye/Dockerfile Outdated Show resolved Hide resolved
dduportal
dduportal requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! This is really a nice job!

However, there are 2 (minor but blocking) changes to be made:

  • The target field should be set outside the args blocks
  • The LABEL filed in the `Dockerfile should be moved to the "common" debian stage.

17/bullseye/Dockerfile Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
dduportal
dduportal approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@dduportal dduportal added the bug label Nov 2, 2022
@dduportal dduportal merged commit 05167ca into jenkinsci:master Nov 2, 2022
@dduportal dduportal mentioned this pull request Nov 2, 2022
Closed
4 tasks
@nagyo nagyo mentioned this pull request Nov 15, 2022
Closed
@dduportal dduportal mentioned this pull request Nov 15, 2022
Open
dduportal added a commit to dduportal/docker-agent that referenced this pull request Nov 16, 2022
@dduportal
fix(debian_jdk17) revert jenkinsci#310 and use to detect if arm/v7 or…
0217d06 
… not

Signed-off-by: Damien Duportal <[email protected]>
@dduportal dduportal mentioned this pull request Nov 16, 2022
Merged
6 tasks
dduportal added a commit that referenced this pull request Nov 16, 2022
@dduportal
Merge pull request #324 from dduportal/fix/debian_jdk17/cpu-archs
50cd097 
fix(debian_jdk17) revert #310 and use `TARGETPLATFORM` to detect if arm/v7 or not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemeurherve lemeurherve lemeurherve left review comments

@gounthar gounthar gounthar left review comments

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JDK 17 ARM64 doesnt work - Java cannot run in AWS Fargate
4 participants
@carpnick @gounthar @dduportal @lemeurherve