Modernize to latest versions supported by Java 8 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePluginForJava8?organizationId=SmVua2lucyBDSQ%3D%3D Co-authored-by: Moderne <[email protected]>
According to the javadocs, this condition does not happen
Replace deprecated Run#getLogFile() method with preferred #getLogReader(). Method has been deprecated since jenkinsci/jenkins#3963 in April 2019.
|
@olivergondza would you be able to review this one or recommend someone who could? I see you've merged the most recent PRs, but those were a few years ago. |
|
Thanks Oliver! |
This was referenced Aug 17, 2023
Closed
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big.
This PR was generated with an OpenRewrite recipe on Moderne.io.
Testing done
Ran
mvn clean verify. Manually fixed four issues flagged by the newer tooling's SpotBugs configuration.Submitter checklist