Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-35414: Folders don't show up in dashboard view #383

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ThomasReinhardt
Copy link

@ThomasReinhardt ThomasReinhardt commented Dec 20, 2024

Fixes #212
This makes the Folders appear again when the Show standard Jenkins list at the top of the page is activated. The standard project list can obviously show items other that just jobs so jobs="${it.jobs}" is too restrictive.

Testing done

Tested manually by adding a Folder to my Dashboard. Did show properly and no warnings or errors were logged.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ThomasReinhardt ThomasReinhardt requested a review from a team as a code owner December 20, 2024 14:57
@TobiX TobiX self-assigned this Dec 25, 2024
@TobiX TobiX added the bug label Dec 25, 2024
@TobiX
Copy link
Contributor

TobiX commented Dec 25, 2024

At first I thought this was a revert of #40, but it actually is a fix for something similar... Good catch.

@TobiX TobiX merged commit 673d549 into jenkinsci:main Dec 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JENKINS-35414] Folders don't show up in dashboard view after upgrade
2 participants