Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove oneEach restriction #369

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

mawinter69
Copy link
Contributor

It is absolutely valid to have multiple iframes or images per area so remove the oneEach restriction

fixes #366

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

It is absolutely valid to have multiple iframe or images per area so
remove the oneEach
@mawinter69 mawinter69 requested a review from a team as a code owner August 14, 2024 15:18
@TobiX TobiX self-assigned this Aug 14, 2024
@TobiX TobiX added the bug label Aug 14, 2024
@TobiX
Copy link
Contributor

TobiX commented Aug 15, 2024

Looks correct, thanks!

@TobiX TobiX merged commit 776ab81 into jenkinsci:main Aug 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dashboard view now only supports one Iframe or Image portlet in each column
2 participants