[JENKINS-69379] Removed obsolete styling in the Add button #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-69379
I have set this to be a draft pull request as I wanted to discuss if this is the correct approach for this fix.
When investigating the black line on the add button issue, I noticed that the other 'Add' buttons on the page didn't include 'jenkins-button' on them.
Example of a non-problematic add button on the same page:
I removed the 'jenkins-button' bits from the jelly file and tested, and now all of the buttons are looking consistent. Manual testing done with problem button:
Do you think this is the right approach? Is there something I am missing about removing the 'jenkins-button' bits from the button?