Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not rely on long deprecated FileOnMasterKeyStoreSource #310

Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Jun 21, 2024

Adapt to jenkinsci/credentials-plugin#540 by not using code about to be removed

Testing done

mvn clean test -Dtest=CertificateMultiBindingTest#basics

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord requested a review from dwnusbaum June 21, 2024 14:38
@jtnord jtnord requested a review from a team as a code owner June 21, 2024 14:38
@olamy olamy merged commit 6288482 into jenkinsci:master Jun 24, 2024
14 checks passed
@jtnord jtnord deleted the remove-use-of-FileOnMasterKeyStoreSource branch June 24, 2024 10:39
@basil
Copy link
Member

basil commented Jul 2, 2024

Incomplete—this PR removed FileOnMasterKeyStoreSource from line 100, but there is still a usage 50 lines down.

@jtnord
Copy link
Member Author

jtnord commented Jul 3, 2024

Incomplete—this PR removed FileOnMasterKeyStoreSource from line 100, but there is still a usage 50 lines down.

#312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants