-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restoring BindingStepTest
#259
Conversation
@SuppressWarnings("rawtypes") | ||
@Test public void configRoundTrip() throws Throwable { | ||
rr.then(r -> { | ||
UsernamePasswordCredentialsImpl c = new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, "creds", "sample", "bob", "s3cr3t"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore ws to review
…n `authorize-project` dep and thus jenkinsci#249
(Marking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took me a while - I was thinking the tests where effected by the conversion of the agent to r.createSlave
and then after a long while I noticed that the Rule
was commented out for story
:)
Like an idiot, in #179 I inadvertently disabled much of the interesting test coverage in this plugin, which was not noticed by reviewers because…I waited for months without review and gave up.