Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring BindingStepTest #259

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Restoring BindingStepTest #259

merged 4 commits into from
Jul 27, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 26, 2023

Like an idiot, in #179 I inadvertently disabled much of the interesting test coverage in this plugin, which was not noticed by reviewers because…I waited for months without review and gave up.

@jglick jglick added the tests label Jul 26, 2023
@jglick jglick requested a review from a team July 26, 2023 17:02
@SuppressWarnings("rawtypes")
@Test public void configRoundTrip() throws Throwable {
rr.then(r -> {
UsernamePasswordCredentialsImpl c = new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, "creds", "sample", "bob", "s3cr3t");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore ws to review

@jglick jglick added developer and removed tests labels Jul 26, 2023
@jglick
Copy link
Member Author

jglick commented Jul 26, 2023

(Marking developer as I would like to have bom builds running these tests again.)

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took me a while - I was thinking the tests where effected by the conversion of the agent to r.createSlave and then after a long while I noticed that the Rule was commented out for story :)

@jtnord jtnord merged commit 8d9034b into jenkinsci:master Jul 27, 2023
13 checks passed
@jglick jglick deleted the BindingStepTest branch July 27, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants