Support deterministic Cobertuna Reports #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhafner
requested changes
Sep 8, 2024
|
|
||
| return packageNode.findOrCreateFileNode(getFileName(fileName), path); | ||
| var relativePath = PATH_UTIL.getRelativePath(fileName); | ||
| var actualPath = relativePath.startsWith("/_/") ? |
There was a problem hiding this comment.
Extract "/_/" as a constant with a meaningful name (deterministic...).
There was a problem hiding this comment.
can't you use String#replaceFirst here?
There was a problem hiding this comment.
Good point! I've replaced the manual prefix check with String#replaceFirst to simplify the logic
| var actualFileName = (fileName != null && fileName.toString().startsWith("/_/")) ? | ||
| fileName.toString().replace("/_/", "./") : | ||
| (fileName != null ? fileName.toString() : relativePath); | ||
| return actualFileName; |
There was a problem hiding this comment.
Please extract the file name logic into a method and reuse it here.
|
whats the status here? is this abandoned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the file path handling in the Coverage plugin to support deterministic builds, addressing issues with paths starting with "/_/". The change ensures compatibility with Coverlet's output format, which uses these paths for deterministic reporting. This adjustment allows the plugin to properly locate and process source files, fixing the problem of missing sources in the coverage reports.
Note: This is a work in progress (WIP) PR. The implementation is still being finalized, and additional testing and adjustments are ongoing.
Testing Done
Automated Tests:
Manual Testing:
Submitter Checklist