Make dep on matrix-project optional
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jul 18, 2024
Comment on lines
+78
to
+83
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>gradle</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
jglick
commented
Jul 18, 2024
Comment on lines
-546
to
+550
| } else if (src instanceof MatrixBuild) { | ||
| } else if (jenkins.getPlugin("matrix-project") != null && src instanceof MatrixBuild) { |
There was a problem hiding this comment.
Compare #14 (amending 4fd5c3e). Without this, the new test fails:
Started
[Pipeline] Start of Pipeline
[Pipeline] node
Running on Jenkins in …/copyartifact-plugin/target/tmp/j h11474560698679713783/workspace/downstream
[Pipeline] {
[Pipeline] copyArtifacts
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
java.lang.ClassNotFoundException: hudson.matrix.MatrixBuild
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
at jenkins.util.URLClassLoader2.findClass(URLClassLoader2.java:35)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
Also: org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: af406f0c-e047-466c-874b-a56e04bfb18a
Caused: java.lang.NoClassDefFoundError: hudson/matrix/MatrixBuild
at hudson.plugins.copyartifact.CopyArtifact.perform(CopyArtifact.java:546)
at jenkins.tasks.SimpleBuildStep.perform(SimpleBuildStep.java:123)
at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:101)
at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:71)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
Finished: FAILURE
Vlatombe
approved these changes
Jul 18, 2024
|
I seem to have write permissions here, though I am not in the dev group…should probably be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned with jenkinsci/htmlpublisher-plugin#287.