Ignore setters which rely on Maps #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
changed the title
timja
approved these changes
May 29, 2019
|
It likely caused a massive regression in the export logic: #902 |
|
NVM, it was another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Please review the guidelines for contributing to this repository.
Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
Please describe what you did
Link to relevant GitHub issues or pull requests
Link to relevant Jenkins JIRA issues
Did you provide a test-case? That demonstrates feature works or fixes the issue.
Description
This is a potential fix for #536
As we do not support yaml Maps (by decision, initial prototype did, but nobody seems to like them) we should just exclude fields/setter which rely on Maps, and at most log a debug message for it