Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space in logs #1049

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Fix space in logs #1049

merged 1 commit into from
Sep 8, 2019

Conversation

timja
Copy link
Member

@timja timja commented Sep 8, 2019

before:

Sep 08, 2019 9:14:47 PM io.jenkins.plugins.casc.Attribute setValue
INFO: Setting hudson.model.Hudson@2ddc1480. systemMessage = Hi

now:

Sep 08, 2019 9:15:22 PM io.jenkins.plugins.casc.Attribute setValue
INFO: Setting [email protected] = Hi

note this will likely break some plugin tests when they upgrade but it's a trivial fix, doing this change now to help get jenkinsci/bom#78 over the line

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
    Fixes Unexpected space between the class name and the attribute name in system logs #1048
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue. - provided down stream test cases 😆

@timja timja added the bugfix A PR that fixes a bug - used by Release Drafter label Sep 8, 2019
@jetersen
Copy link
Member

jetersen commented Sep 8, 2019

Once we have incremental I will submit a PR to ssh-slaves

@timja
Copy link
Member Author

timja commented Sep 8, 2019

I deployed a timestamped snapshot to not wait 👅
jenkinsci/ssh-credentials-plugin#44
1.30-20190908.202458-1

@timja
Copy link
Member Author

timja commented Sep 8, 2019

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep newbie-friendly tickets for newbies :P

@jetersen
Copy link
Member

jetersen commented Sep 8, 2019

@jetersen
Copy link
Member

jetersen commented Sep 8, 2019

There I think I caught all the once affected, so we can go ahead and 🚢 it? 😄

@jetersen jetersen merged commit fa5e40b into jenkinsci:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected space between the class name and the attribute name in system logs
3 participants