Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to Jenkins 2.401.3 with jakarta.inject #97

Conversation

sghill-rewrite
Copy link
Contributor

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

2.401.2 was the first version to include Guice 6.x, which supports jakarta.inject.

Testing done

Ran mvn clean verify.

Submitter checklist

Preview Give feedback

Refs: sghill-rewrite/campaigns#1 sghill-rewrite/campaigns#2

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin

@sghill-rewrite sghill-rewrite requested a review from a team as a code owner December 6, 2023 04:04
@PierreBtz
Copy link
Contributor

@sghill-rewrite thanks for this proposal. I'm trying to keep the baseline so that a one year release can get the plugin.
For the rest I usually bump the baseline manually to make sure I'm not missing anything and I have dependabot for the dependencies.

Can I please get this plugin out of this campaign? Also can you opt-out the audit trail plugin, the shelve project plugin and the Health Advisor plugin?
Thanks!

@PierreBtz PierreBtz closed this Dec 6, 2023
@sghill
Copy link

sghill commented Dec 6, 2023

I can note it down, thanks.

Is this specific to the baseline version, or would you also prefer to avoid any PRs (for example: updating deprecated methods)?

@PierreBtz
Copy link
Contributor

Thanks!

would you also prefer to avoid any PRs (for example: updating deprecated methods)?

Having spent more time than I'd like recently on /javax/jakarta and friends, I'd like to still receive other PRs.

Thanks for your effort on this, it's useful (even if in the case of version update I currently think I'm good with a combination of dependabot + manual decisions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants