Many Improvements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remove() operation performs this check itself.
Running FindBugs is already configured in the parent pom. Due to a different execution id FindBugs was run twice.
Using Java 8 as Java 7 is end of life since quite a while. The removed plugins are already defined in the parent pom.
It's annotated with `@Nonnull` now and throws an exception if no instance is available. Therefore `null` checks are not required anymore.
`getRootPath()` is annotated with `@Nonnull`, therefore never returns `null`.
|
I left Cloudbees 2 months ago ;) |
|
@ndeloof good luck. @aheritier who could have a look at this? |
Closed
aheritier
approved these changes
Oct 10, 2019
| @@ -37,14 +37,9 @@ | |||
| */ | |||
| @Initializer(after = InitMilestone.JOB_LOADED) | |||
| public static void initialize() { | |||
| // TODO switch to Jenkins.getActiveInstance() once 1.590+ is the baseline | |||
| Jenkins jenkins = Jenkins.getInstance(); | |||
There was a problem hiding this comment.
I think it's ok to be compatible with 2.60+ (it's changing too often :-) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ndeloof can you have a look at this or ask a colleague to do so?