Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump analysis-pom from 4.7.0 to 5.0.0 #89

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2021

Bumps analysis-pom from 4.7.0 to 5.0.0.

Release notes

Sourced from analysis-pom's releases.

v5.0.0 🎁

🔧 Internal changes

  • Use Jenkins 2.249 as baseline and support JDK 11 builds (#214) @​uhafner

📦 Dependency updates

Commits
  • 6bd7e65 [maven-release-plugin] prepare release v5.0.0
  • bfa9199 Bump version to 5.0.0.
  • 153581e [maven-release-plugin] prepare for next development iteration
  • 33f5548 [maven-release-plugin] prepare release v5.0.0-beta-3
  • fc0e3d7 Merge pull request #214 from jenkinsci/jenkins-2.249
  • 3d982b0 Merge pull request #213 from jenkinsci/dependabot/maven/org.pitest-pitest-mav...
  • 7b85057 Merge pull request #217 from jenkinsci/dependabot/maven/archunit.version-0.17.0
  • 05ca0ce Merge pull request #218 from jenkinsci/dependabot/maven/org.mockito-mockito-c...
  • 46e0a96 Bump version of PMD to 6.31.0.
  • 399e320 [maven-release-plugin] prepare for next development iteration
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 1, 2021
@XiongKezhi
Copy link
Contributor

the rev-api failed on dependencies: https://ci.jenkins.io/blue/rest/organizations/jenkins/pipelines/Plugins/pipelines/checks-api-plugin/branches/PR-89/runs/1/nodes/8/steps/59/log/?start=0

should we ignore the dependencies while upgrading the version number @uhafner @timja

@timja
Copy link
Member

timja commented Mar 1, 2021

Some sort of ignore is needed I expect

@uhafner
Copy link
Member

uhafner commented Mar 1, 2021

Yes, I disabled the dependencies checks in the warnings plugin: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/pom.xml#L652

There you can also get an impression on how to use the ignores for annotations.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #89 (ef94ff2) into master (1e1ac7e) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     87.57%   87.46%   -0.11%     
  Complexity      148      148              
============================================
  Files            17       17              
  Lines           708      710       +2     
  Branches         54       54              
============================================
+ Hits            620      621       +1     
- Misses           70       71       +1     
  Partials         18       18              
Impacted Files Coverage Δ Complexity Δ
...enkins/plugins/checks/steps/PublishChecksStep.java 91.04% <ø> (ø) 21.00 <0.00> (ø)
...o/jenkins/plugins/checks/steps/WithChecksStep.java 74.71% <50.00%> (-0.87%) 2.00 <0.00> (ø)
...o/jenkins/plugins/checks/api/ChecksAnnotation.java 100.00% <100.00%> (ø) 12.00 <1.00> (ø)
...a/io/jenkins/plugins/checks/api/ChecksDetails.java 100.00% <100.00%> (ø) 10.00 <1.00> (ø)
...va/io/jenkins/plugins/checks/api/ChecksOutput.java 95.34% <100.00%> (ø) 8.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1ac7e...27ce721. Read the comment docs.

@@ -129,6 +131,8 @@ public String toString() {
/**
* Constructs a builder for {@link ChecksAnnotation}.
*/
@SuppressFBWarnings(value = "NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the fields are nullable then you rather should mark them so using @CheckForNull. (Or the other way round change the default.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants