-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump analysis-pom from 4.7.0 to 5.0.0 #89
Bump analysis-pom from 4.7.0 to 5.0.0 #89
Conversation
Bumps [analysis-pom](https://github.com/jenkinsci/analysis-pom-plugin) from 4.7.0 to 5.0.0. - [Release notes](https://github.com/jenkinsci/analysis-pom-plugin/releases) - [Changelog](https://github.com/jenkinsci/analysis-pom-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/analysis-pom-plugin@v4.7.0...v5.0.0) Signed-off-by: dependabot[bot] <[email protected]>
the rev-api failed on dependencies: https://ci.jenkins.io/blue/rest/organizations/jenkins/pipelines/Plugins/pipelines/checks-api-plugin/branches/PR-89/runs/1/nodes/8/steps/59/log/?start=0 should we ignore the dependencies while upgrading the version number @uhafner @timja |
Some sort of ignore is needed I expect |
Yes, I disabled the dependencies checks in the warnings plugin: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/pom.xml#L652 There you can also get an impression on how to use the ignores for annotations. |
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
============================================
- Coverage 87.57% 87.46% -0.11%
Complexity 148 148
============================================
Files 17 17
Lines 708 710 +2
Branches 54 54
============================================
+ Hits 620 621 +1
- Misses 70 71 +1
Partials 18 18
Continue to review full report at Codecov.
|
@@ -129,6 +131,8 @@ public String toString() { | |||
/** | |||
* Constructs a builder for {@link ChecksAnnotation}. | |||
*/ | |||
@SuppressFBWarnings(value = "NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the fields are nullable then you rather should mark them so using @CheckForNull
. (Or the other way round change the default.)
Bumps analysis-pom from 4.7.0 to 5.0.0.
Release notes
Sourced from analysis-pom's releases.
Commits
6bd7e65
[maven-release-plugin] prepare release v5.0.0bfa9199
Bump version to 5.0.0.153581e
[maven-release-plugin] prepare for next development iteration33f5548
[maven-release-plugin] prepare release v5.0.0-beta-3fc0e3d7
Merge pull request #214 from jenkinsci/jenkins-2.2493d982b0
Merge pull request #213 from jenkinsci/dependabot/maven/org.pitest-pitest-mav...7b85057
Merge pull request #217 from jenkinsci/dependabot/maven/archunit.version-0.17.005ca0ce
Merge pull request #218 from jenkinsci/dependabot/maven/org.mockito-mockito-c...46e0a96
Bump version of PMD to 6.31.0.399e320
[maven-release-plugin] prepare for next development iterationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)