Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for annotations in publish checks step. #87

Merged
merged 3 commits into from
Feb 28, 2021
Merged

Conversation

XiongKezhi
Copy link
Contributor

Solve #28.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #87 (ff9bbff) into master (6fda320) will increase coverage by 0.45%.
The diff coverage is 82.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     87.11%   87.57%   +0.45%     
- Complexity      142      148       +6     
============================================
  Files            16       17       +1     
  Lines           652      708      +56     
  Branches         49       54       +5     
============================================
+ Hits            568      620      +52     
- Misses           66       70       +4     
  Partials         18       18              
Impacted Files Coverage Δ Complexity Δ
...enkins/plugins/checks/steps/PublishChecksStep.java 91.04% <80.70%> (+0.56%) 21.00 <2.00> (+2.00)
...ava/io/jenkins/plugins/checks/steps/StepUtils.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fda320...848e40a. Read the comment docs.

@XiongKezhi
Copy link
Contributor Author

I'll file a separate PR to split checks models from the step class to solve the PMD warning.

@XiongKezhi XiongKezhi requested a review from timja February 23, 2021 15:24
@XiongKezhi
Copy link
Contributor Author

@timja do you have time to review this? thanks

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested manually but looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants