Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString for api models #8

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Add toString for api models #8

merged 3 commits into from
Aug 10, 2020

Conversation

XiongKezhi
Copy link
Contributor

@XiongKezhi XiongKezhi commented Aug 9, 2020

I'm not sure if this is the right (or easiest) way to write the toString for our api models since we have so many nullable fields.

@XiongKezhi XiongKezhi added enhancement New feature or request chore labels Aug 9, 2020
@XiongKezhi XiongKezhi requested a review from a team August 9, 2020 09:31
@XiongKezhi XiongKezhi self-assigned this Aug 9, 2020
@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #8 into master will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     82.12%   82.54%   +0.42%     
- Complexity       44       49       +5     
============================================
  Files            10       10              
  Lines           207      212       +5     
  Branches          7        7              
============================================
+ Hits            170      175       +5     
  Misses           37       37              
Impacted Files Coverage Δ Complexity Δ
...va/io/jenkins/plugins/checks/api/ChecksAction.java 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
...o/jenkins/plugins/checks/api/ChecksAnnotation.java 100.00% <100.00%> (ø) 12.00 <1.00> (+1.00)
...a/io/jenkins/plugins/checks/api/ChecksDetails.java 100.00% <100.00%> (ø) 10.00 <1.00> (+1.00)
...ava/io/jenkins/plugins/checks/api/ChecksImage.java 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
...va/io/jenkins/plugins/checks/api/ChecksOutput.java 100.00% <100.00%> (ø) 8.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e3687...2f1d4eb. Read the comment docs.

@uhafner uhafner self-requested a review August 10, 2020 14:36
@XiongKezhi XiongKezhi merged commit e4e4fce into master Aug 10, 2020
@XiongKezhi XiongKezhi deleted the add-to-string branch August 10, 2020 14:38
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
Use GitHubAppCrendential from github-branch-source
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
…-2.11.1

Bump jackson.version from 2.10.2 to 2.11.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants