Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore stage graph output while checking out #77

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Ignore stage graph output while checking out #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public void onCheckout(final Run<?, ?> run, final SCM scm, final FilePath worksp
final TaskListener listener, @CheckForNull final File changelogFile,
@CheckForNull final SCMRevisionState pollingBaseline) {
getChecksName(run).ifPresent(checksName -> publish(ChecksPublisherFactory.fromRun(run, listener),
ChecksStatus.IN_PROGRESS, ChecksConclusion.NONE, checksName, getOutput(run)));
ChecksStatus.IN_PROGRESS, ChecksConclusion.NONE, checksName, null));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't we missing the title as well? have you tested this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it seems fine, I can't find any issues with it.

I was also looking into this, and found 2 options:

  1. the same fix as you
  2. check the workspace on checkout and if it contains '@libs' we skip it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves the NPE and the title will simply be "in progress" which is automatically added by GitHub as before. And for pipeline users, the title of the check will be updated when a new stage/branch is triggered.

}
}

Expand Down