Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure to title #76

Merged
merged 7 commits into from
Feb 6, 2021
Merged

Add failure to title #76

merged 7 commits into from
Feb 6, 2021

Conversation

timja
Copy link
Member

@timja timja commented Feb 5, 2021

image

image

image

Happy to change the naming:

$branchLabel: $status in $step step

I've tested quite a few cases and all seems to work, imported some code from the junit plugin so we can get the stage names from a child FlowNode

The test pipeline doesn't have any nested stages or parallel but the tests do and it ends up being:

'stage/parallelBranch/stage'

the test text:
'In parallel/p1/p1s1: warning in 'unstable' step'

@mrginglymus FYI

@timja timja requested a review from XiongKezhi February 5, 2021 23:09
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #76 (bce938b) into master (22f6a7c) will decrease coverage by 0.85%.
The diff coverage is 80.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
- Coverage     88.19%   87.33%   -0.86%     
- Complexity      127      139      +12     
============================================
  Files            16       16              
  Lines           593      624      +31     
  Branches         36       47      +11     
============================================
+ Hits            523      545      +22     
- Misses           59       63       +4     
- Partials         11       16       +5     
Impacted Files Coverage Δ Complexity Δ
...s/plugins/checks/status/FlowExecutionAnalyzer.java 80.57% <80.48%> (-2.76%) 44.00 <13.00> (+12.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f6a7c...f08b9a9. Read the comment docs.

@timja
Copy link
Member Author

timja commented Feb 6, 2021

It’s best to say what you’re requesting changes on specifically, neither of your comments appear especially critical

@XiongKezhi XiongKezhi dismissed their stale review February 6, 2021 07:44

only specific comments

@timja timja requested a review from XiongKezhi February 6, 2021 09:28
@timja timja added the enhancement New feature or request label Feb 6, 2021
@timja timja merged commit de42444 into jenkinsci:master Feb 6, 2021
@timja timja deleted the add-failure-to-title branch February 6, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants