-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failure to title #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
============================================
- Coverage 88.19% 87.33% -0.86%
- Complexity 127 139 +12
============================================
Files 16 16
Lines 593 624 +31
Branches 36 47 +11
============================================
+ Hits 523 545 +22
- Misses 59 63 +4
- Partials 11 16 +5
Continue to review full report at Codecov.
|
src/main/java/io/jenkins/plugins/checks/status/FlowExecutionAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/checks/status/FlowExecutionAnalyzer.java
Outdated
Show resolved
Hide resolved
It’s best to say what you’re requesting changes on specifically, neither of your comments appear especially critical |
Happy to change the naming:
$branchLabel: $status in $step step
I've tested quite a few cases and all seems to work, imported some code from the junit plugin so we can get the stage names from a child
FlowNode
The test pipeline doesn't have any nested stages or parallel but the tests do and it ends up being:
'stage/parallelBranch/stage'
the test text:
'In parallel/p1/p1s1: warning in 'unstable' step'
@mrginglymus FYI