Add LoggingChecksPublisher and tests for status checks #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
XiongKezhi
force-pushed
the
add_test_for_status_checks
branch
from
edde6d8 to
8e87b22
Compare
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
============================================
+ Coverage 77.97% 83.79% +5.82%
- Complexity 75 78 +3
============================================
Files 14 14
Lines 395 395
Branches 16 16
============================================
+ Hits 308 331 +23
+ Misses 82 58 -24
- Partials 5 6 +1
Continue to review full report at Codecov.
|
timja
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging checks publisher is still needed for status checks test besides capturing details publisher since we cannot verify the details of the checks in the middle of a build.