Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish checks for job and use task listener #4

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

XiongKezhi
Copy link
Contributor

  • Publish checks fro job directly instead of run and item
  • Add task listener for console log

@XiongKezhi XiongKezhi requested a review from a team August 3, 2020 05:37
@XiongKezhi XiongKezhi self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #4 into master will increase coverage by 4.53%.
The diff coverage is 35.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     78.39%   82.92%   +4.53%     
- Complexity       38       44       +6     
============================================
  Files            10       10              
  Lines           199      205       +6     
  Branches          6        7       +1     
============================================
+ Hits            156      170      +14     
+ Misses           43       35       -8     
Impacted Files Coverage Δ Complexity Δ
...ins/plugins/checks/BuildStatusChecksPublisher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...io/jenkins/plugins/checks/api/ChecksPublisher.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ins/plugins/checks/api/ChecksPublisherFactory.java 82.35% <62.50%> (+82.35%) 6.00 <5.00> (+6.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b280cf...26e46eb. Read the comment docs.

@XiongKezhi XiongKezhi added enhancement New feature or request and removed breaking changes labels Aug 3, 2020
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll need a PR to warnings-ng as well I think?

@XiongKezhi
Copy link
Contributor Author

it'll need a PR to warnings-ng as well I think?

maybe it will be better to remove the abstract from job one since in most cases it will not be needed, and no need to change warnings as well.

@XiongKezhi XiongKezhi merged commit 3d21dbb into master Aug 4, 2020
@XiongKezhi XiongKezhi deleted the publish-checks-for-job branch August 4, 2020 03:04
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
Update readme and doc diagrams
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants