-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old GitHub action with updated one. #247
Conversation
BuildStatusChecksPublisherITest.shouldPublishStageDetails:185 fails on windows on Java 21 |
# Conflicts: # src/test/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisherITest.java
@timja Do you have an idea why the output is
|
not sure =/ |
@@ -89,7 +89,7 @@ private Pair<String, String> processStageOrBranchRow(final FlowGraphTable.Row ro | |||
if (row.getNode().isActive()) { | |||
nodeTextBuilder.append(" *(running)*"); | |||
} | |||
else if (row.getDurationMillis() > 0) { | |||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timja I removed the guard as FlowGraphTable.Row
correctly handles the case where duration = 0. This makes the test run on all platforms now.
The old one still used unsupported Java 11 JDK.