Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old GitHub action with updated one. #247

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Replace old GitHub action with updated one. #247

merged 9 commits into from
Mar 4, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 27, 2024

The old one still used unsupported Java 11 JDK.

@uhafner uhafner added the github_actions Pull requests that update Github_actions code label Feb 27, 2024
@timja
Copy link
Member

timja commented Feb 27, 2024

BuildStatusChecksPublisherITest.shouldPublishStageDetails:185

fails on windows on Java 21

@uhafner
Copy link
Member Author

uhafner commented Feb 28, 2024

@timja Do you have an idea why the output is p1s2 without a time on Windows 21?
I even did not found the code that produces this part.

Optional[  * Simple Stage *(15 ms)*
  * In parallel *(0.15 sec)*
    * p1 *(15 ms)*
      * p1s1 *(32 ms)*
        **Unstable**: *something went wrong*
      * p1s2
    * p2 *(15 ms)*
  * Fails *(31 ms)*
    **Error**: *a fatal error occurs*

@timja
Copy link
Member

timja commented Feb 28, 2024

not sure =/

@@ -89,7 +89,7 @@ private Pair<String, String> processStageOrBranchRow(final FlowGraphTable.Row ro
if (row.getNode().isActive()) {
nodeTextBuilder.append(" *(running)*");
}
else if (row.getDurationMillis() > 0) {
else {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timja I removed the guard as FlowGraphTable.Row correctly handles the case where duration = 0. This makes the test run on all platforms now.

@uhafner uhafner requested a review from timja February 29, 2024 12:12
@timja timja merged commit ad30099 into master Mar 4, 2024
20 checks passed
@timja timja deleted the github-ci branch March 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants