Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commons-text-api dependency #234

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Conversation

timja
Copy link
Member

@timja timja commented Sep 17, 2023

Fixes #233

Testing done

Submitter checklist

Preview Give feedback

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #234 (0382b29) into master (33c675e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage     85.38%   85.38%           
  Complexity      152      152           
=========================================
  Files            17       17           
  Lines           746      746           
  Branches         57       57           
=========================================
  Hits            637      637           
  Misses           89       89           
  Partials         20       20           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timja timja merged commit 98ed22d into jenkinsci:master Sep 17, 2023
17 checks passed
@timja timja deleted the add-dependencies branch September 17, 2023 16:19
@jglick
Copy link
Member

jglick commented Sep 18, 2023

I would recommend ceasing to use analysis-pom as a parent.

@timja
Copy link
Member Author

timja commented Sep 18, 2023

I would recommend ceasing to use analysis-pom as a parent.

agreed but this was a minimum quick change, (PRs welcome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies of flattened POM of latest release do not match MANIFEST.MF
2 participants