Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation guide #22

Merged
merged 5 commits into from
Aug 28, 2020
Merged

Add implementation guide #22

merged 5 commits into from
Aug 28, 2020

Conversation

XiongKezhi
Copy link
Contributor

No description provided.

@XiongKezhi XiongKezhi requested a review from a team August 27, 2020 13:27
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage     90.87%   90.87%           
  Complexity       69       69           
=========================================
  Files            11       11           
  Lines           274      274           
  Branches          6        6           
=========================================
  Hits            249      249           
  Misses           23       23           
  Partials          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed55d9f...89c83b8. Read the comment docs.

@@ -0,0 +1,33 @@
# Implementation Guide

This document guides you how to implement this checks API for a specific remote SCM platform.
Copy link
Member

@timja timja Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document guides you how to implement this checks API for a specific remote SCM platform.
This document will show you how to implement the checks API for a specific SCM platform.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some code examples might be good

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the minor nits I added suggestions on

docs/implementation-guide.md Outdated Show resolved Hide resolved
docs/implementation-guide.md Outdated Show resolved Hide resolved
docs/implementation-guide.md Outdated Show resolved Hide resolved
docs/implementation-guide.md Outdated Show resolved Hide resolved
@XiongKezhi XiongKezhi merged commit ab0c0e9 into master Aug 28, 2020
@XiongKezhi XiongKezhi deleted the implementation-guide branch August 28, 2020 09:17
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
Add mock server test for GitHub check run publishing
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants