Ignore stage graph output while checking out #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
============================================
- Coverage 87.33% 87.31% -0.03%
Complexity 139 139
============================================
Files 16 16
Lines 624 623 -1
Branches 47 47
============================================
- Hits 545 544 -1
Misses 63 63
Partials 16 16
Continue to review full report at Codecov.
|
| @@ -150,7 +150,7 @@ public void onCheckout(final Run<?, ?> run, final SCM scm, final FilePath worksp | |||
| final TaskListener listener, @CheckForNull final File changelogFile, | |||
| @CheckForNull final SCMRevisionState pollingBaseline) { | |||
| getChecksName(run).ifPresent(checksName -> publish(ChecksPublisherFactory.fromRun(run, listener), | |||
| ChecksStatus.IN_PROGRESS, ChecksConclusion.NONE, checksName, getOutput(run))); | |||
| ChecksStatus.IN_PROGRESS, ChecksConclusion.NONE, checksName, null)); | |||
There was a problem hiding this comment.
won't we missing the title as well? have you tested this?
There was a problem hiding this comment.
I've tested it and it seems fine, I can't find any issues with it.
I was also looking into this, and found 2 options:
- the same fix as you
- check the workspace on checkout and if it contains '@libs' we skip it
There was a problem hiding this comment.
It solves the NPE and the title will simply be "in progress" which is automatically added by GitHub as before. And for pipeline users, the title of the check will be updated when a new stage/branch is triggered.
|
Thanks for the fix! |
A quick fix for https://issues.jenkins.io/browse/JENKINS-64813
checking out pipeline library will trigger our listener although there is no flow graph available, so an NEP occurs.