-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-47882 Upgrade mongo client to 3.x and jackson to 2.x #89
Conversation
Previously there was an active authentication and we handled the authentication, now it is done as part of the client
src/test/java/com/sonyericsson/jenkins/plugins/bfa/db/EmbeddedMongoStatisticsTest.java
Outdated
Show resolved
Hide resolved
34cacf4
to
b8be9b5
Compare
@rsandell can you please review? |
@timja by merging your other PRs this now needs to resolve some merge conflicts :) |
done @rsandell most trivial resolve ever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some good/"simple" way to test that a old database stored by the old code/driver can be read back using this code?
src/main/java/com/sonyericsson/jenkins/plugins/bfa/model/indication/FoundIndication.java
Outdated
Show resolved
Hide resolved
Not that I'm aware of, but upgrading the driver was able to read old data just fine. |
…in into upgrade-minimal-changes
After this change, I'm unable to connect to Mongo v3.4.18 , but rolling back to the previous version (of the plugin) I can again. Is there some sort of migration or re-configuration required to make this work? |
shouldn't be, i'm using 4.x but the tests are using 3.6 are you using authentication? |
Tried with and without, with the same results. |
I'll try take a look in a couple of days, looking at the docs the version is supported: |
What stacktrace do you get @wfreemanben ? I tried it out, and had trouble with no authentication, but with this PR I'm able to connect fine to 3.4.18: |
Note,
I've tried to upgrade dependencies but not APIs in this PR, there's deprecated code and new apis that should be used in a follow up PR.
This PR will make allowing the use of SSL simple (https://issues.jenkins-ci.org/browse/JENKINS-45315)
This may resolve https://issues.jenkins-ci.org/browse/JENKINS-49140 or at least make it much easier to achieve