Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-47882 Upgrade mongo client to 3.x and jackson to 2.x #89

Merged
merged 28 commits into from
Dec 6, 2018

Conversation

timja
Copy link
Member

@timja timja commented Nov 2, 2018

Note,
I've tried to upgrade dependencies but not APIs in this PR, there's deprecated code and new apis that should be used in a follow up PR.

This PR will make allowing the use of SSL simple (https://issues.jenkins-ci.org/browse/JENKINS-45315)

This may resolve https://issues.jenkins-ci.org/browse/JENKINS-49140 or at least make it much easier to achieve

@timja timja changed the title [WIP] JENKINS-47882 Upgrade mongo client to 3.x and jackson to 2.x JENKINS-47882 Upgrade mongo client to 3.x and jackson to 2.x Nov 3, 2018
@timja timja force-pushed the upgrade-minimal-changes branch from 34cacf4 to b8be9b5 Compare November 8, 2018 16:33
@timja
Copy link
Member Author

timja commented Nov 13, 2018

@rsandell can you please review?

@rsandell
Copy link
Member

@timja by merging your other PRs this now needs to resolve some merge conflicts :)

@timja
Copy link
Member Author

timja commented Nov 28, 2018

done @rsandell most trivial resolve ever

Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some good/"simple" way to test that a old database stored by the old code/driver can be read back using this code?

@timja
Copy link
Member Author

timja commented Nov 28, 2018

Not that I'm aware of, but upgrading the driver was able to read old data just fine.
the old driver also worked on new mongo
except for authentication methods, i.e. old driver couldn't handle the new required auth mechanisms

@rsandell rsandell merged commit 25f821c into jenkinsci:master Dec 6, 2018
@wfreemanben
Copy link

wfreemanben commented Jan 16, 2019

After this change, I'm unable to connect to Mongo v3.4.18 , but rolling back to the previous version (of the plugin) I can again. Is there some sort of migration or re-configuration required to make this work?

@timja timja deleted the upgrade-minimal-changes branch January 16, 2019 16:58
@timja
Copy link
Member Author

timja commented Jan 16, 2019

shouldn't be, i'm using 4.x but the tests are using 3.6
https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/89/files#diff-b49a3adcb5396a868ad161dea2330235R85

are you using authentication?

@wfreemanben
Copy link

Tried with and without, with the same results.

@timja
Copy link
Member Author

timja commented Jan 16, 2019

I'll try take a look in a couple of days, looking at the docs the version is supported:
http://mongodb.github.io/mongo-java-driver/3.8/upgrading/

@timja
Copy link
Member Author

timja commented Jan 18, 2019

What stacktrace do you get @wfreemanben ?

I tried it out, and had trouble with no authentication, but with this PR I'm able to connect fine to 3.4.18:
#95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants