[JENKINS-48932] - Update plugin to make it runable with PCT #83
Conversation
…ent Jenkins core versions
…v/build-failure-analyzer-plugin into oleg-nenashev-JENKINS-48932/jep-200
| @@ -659,7 +659,7 @@ public void setLastFailedBuildUrl() { | |||
|
|
|||
| @Override | |||
| public String getDisplayName() { | |||
| return null; | |||
| return ""; | |||
There was a problem hiding this comment.
Just delete this override altogether.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -659,7 +659,7 @@ public void setLastFailedBuildUrl() { | |||
|
|
|||
| @Override | |||
| public String getDisplayName() { | |||
| return null; | |||
| return ""; | |||
There was a problem hiding this comment.
IIRC it can be already removed in this version... or not?
There was a problem hiding this comment.
Even on 1.625 it was @Nonnull
| @@ -128,12 +129,19 @@ public void run() { | |||
| if (build instanceof AbstractBuild) { | |||
| AbstractBuild abstractBuild = (AbstractBuild)build; | |||
| Node node = abstractBuild.getBuiltOn(); | |||
| nodeName = node.getNodeName(); | |||
| if (node != null) { | |||
| nodeName = node.getNodeName(); | |||
There was a problem hiding this comment.
Probably you just want to fail the run, but OK
There was a problem hiding this comment.
It is set to unknown above.
|
|
||
| String result = "Unknown"; | ||
| final Result buildResult = build.getResult(); | ||
| if (buildResult != null) { |
There was a problem hiding this comment.
Maybe result should be "Running" according to the getResult() docs
There was a problem hiding this comment.
This code shouldn't execute until after the run is done (for now) so a null here would mean unknown and something is wrong, but I don't want to skip logging the statistics just for that.
There was a problem hiding this comment.
Any Build Step may actually change this expectation. Better safe than sorry
| } | ||
| return plugin; |
There was a problem hiding this comment.
hmm... FindBugs should be fine with that
Replaces #81 with test, findbugs and checkstyle fixes.
Bumped all the way up to Jenkins Core 2.7 since even that is fairly old by now and has more findbugs annotations to adhere to.
@reviewbybees