Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code quality fix-4 #46

Merged
merged 1 commit into from
Feb 26, 2016
Merged

General code quality fix-4 #46

merged 1 commit into from
Feb 26, 2016

Conversation

faisal-hameed
Copy link
Contributor

This pull request is focused on resolving occurrences of Sonar rule
squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding.
squid:MissingDeprecatedCheck - Deprecated elements should have both the annotation and the Javadoc tag.
squid:S1700 - A field should not duplicate the name of its containing class.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck
https://dev.eclipse.org/sonar/rules/show/squid:MissingDeprecatedCheck
https://dev.eclipse.org/sonar/rules/show/squid:S1700

Please let me know if you have any questions.

Faisal Hameed

@rsandell
Copy link
Member

One test failure, seems to be due to it expecting the name of the semaphore field.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@faisal-hameed
Copy link
Contributor Author

@rsandell Test is passing now.

rsandell added a commit that referenced this pull request Feb 26, 2016
@rsandell rsandell merged commit a01f254 into jenkinsci:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants