Add support for the folders plugin #36
Conversation
|
This initial build will fail because of the jenkins version bump. |
|
The actual folders support will come next |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
No new failures were added from my code addition. The test failures are related to the minimum jenkins version bump. Unfortunately, I'm not a java developer and I'm really not familiar with Java or even Jenkins unit testing framework to fix the failing issues. Help from someone with a depth knowledge of it would be greatly appreciated in order to get this into the next release. I am using my code changes in a Jenkins instance and it's working as supposed. |
|
When I started to dig into fixing the unit tests I noticed that some of |
|
So, it fails when Jenkins is served from |
|
Yes, |
|
Want me to try and address this issue in this PR, or are you intending on pushing your fixed tests with the bumped Jenkins version to the master branch(or any other branch) and I'll rebase and fix? |
|
I stopped once I noticed that the algorithm was wrong, so I've only done pom changes and checkstyle fixes so far. But I can push the few things that I've done and you can pull that to your fork if you want to. |
|
I think that I've taken care of the existance(or not) of a URL prefix... Let's see what the tests say.... |
|
Seems like it needs some more tweaking ;) |
| @@ -57,7 +56,6 @@ | |||
| /** | |||
| * @param pattern the String value. | |||
| */ | |||
| @DataBoundConstructor | |||
There was a problem hiding this comment.
I no longer remember why... I can get that back in if desirable...
|
As soon as the Jenkins version is bumped the failures start happening. I tried cherry picking your LTS commits into master to confirm this, and, the master branch with the Jenkins version bump failures seem exactly the same as those in this PR. I am, by no means, a Java developer, so, much of this code was done by try and failing and reading other peoples code. If I could get a hold on a branch where the Jenkins version is bumped and the don't tests fail, that would be way more simple for me to apply this PR against and know if the failures are from my code or not.... |
|
Updated my previous comment(it was written on mobile and had some bad phrases in there)... |
| * that comes before the first '/job' occurrent which is either nothing or the | ||
| * prefix from where jenkins is served, ie: http://localhost/jenkins/job/<job>/<buildNumber> | ||
| */ | ||
| String interestingJobParts = urlParts[0].split("/job", 2)[-1]; |
|
I have managed to fix most of the tests to some degree. What I found so far is that the failures in |
|
I fixed all other test failures except those failed to your change on the same branch as before |
Just converted to JenkinsRule to see if that helped things
And fixed some checkstyle errors
|
The reason for the data bound question... |
|
I've cherry-picked your changes into [https://github.com/s0undt3ch/build-failure-analyzer-plugin/tree/features/bump-to-lts]. As you mentioned, the tests pass. Thank You! I'll apply my feature on top of that. |
|
Yes a simple look in the git history revealed that I was the one who removed it :) You should be able to simply pull the branch instead if cherry picking, I pulled from yours and just added my commit. A cherry pick would duplicate that commit which might be unnessesary. |
|
Updated some code..... Dam! It still fails... |
Folder jobs must then have more that two, `/job` occurrences in the first array element.
|
The tests now pass but this is still not correct... |
|
The mongo tests don't fail locally. Closing and reopening to trigger a new build(if this is how it works)... |
|
Ok, I have no idea why the mongo tests are failing(they aren't locally)... does this makes any sense to you @rsandell? |
|
It could be a timezone issue. It's a bit cumbersome for me to pull down your changes since you did a cherry pick instead of a merge/pull, but I'll muster through it ;) |
|
@rsandell Sorry.... Want me to do a clean PR? |
|
Nope, no worries. I got it running locally. It seems to be a jdk 8 vs jdk 7 issue. Thanks for all your work! |
Add support for the folders plugin
|
AWESOME!!!! 🎆 |
No description provided.