Configurable anonymous access to the list of failure causes #31

dcoraboeuf · 2015-01-14T12:38:51Z

In some contexts, it is interesting to provide authorised users a read-only access to list of failure causes.

This pull request creates a new ViewCauses permission, granted automatically for users having already UpdateCauses. When a user has this ViewCauses permission granted, he can access the list of existing failures.

Best regards,
Damien.

jenkinsadmin · 2015-01-14T13:01:02Z

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

dcoraboeuf · 2015-01-14T13:18:45Z

The build failed because of Checkstyle errors - but no detail is given in the build :( Any idea?

dcoraboeuf · 2015-01-14T13:46:37Z

Checkstyle issue fixed.

rsandell · 2015-01-14T15:14:20Z

src/main/resources/com/sonyericsson/jenkins/plugins/bfa/CauseManagement/index.groovy

@@ -32,7 +32,7 @@ def f = namespace(lib.FormTagLib)
 def l = namespace(lib.LayoutTagLib)
 def j = namespace(lib.JenkinsTagLib)

-l.layout(permission: PluginImpl.UPDATE_PERMISSION) {


Since VIEW_PERMISSION is inferred by UPDATE_PERMISSION you should be able to put permission: PluginImpl.VIEW_PERMISSION here for safety.

rsandell · 2015-01-14T15:19:39Z

A test case or two testing the permissions are working as expected would be nice.

Example:
Permissions: Alice can update, Bob can only view, Charles can't do anything (only overall read).

Alice and bob sees the link on Jenkins Root and job pages, Charles does not.
Alice and bob can navigate to the action page, Charles can not.
Alice can open the details page and sees the new button, Bob and Charles does not.

There are some helper methods in JenkinsRule to help you setup security and test these scenarios.

dcoraboeuf · 2015-01-14T15:39:09Z

I'll work on the tests a bit later today.

AnneTheAgile · 2015-01-14T16:02:54Z

Although it doesn't show up here, the checkstyle still seems to be failing?
https://jenkins.ci.cloudbees.com/job/plugins/job/build-failure-analyzer-plugin/90/console

INFO: Stopping build-failure-analyzer
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.117 sec

Results :

Tests run: 148, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.13:check (test-check) @ build-failure-analyzer ---
[INFO] 
[INFO] There are 1 checkstyle errors.
[ERROR] CauseManagement.java[118:78] (whitespace) OperatorWrap: '||' should be on a new line.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:57 min
[INFO] Finished at: 2015-01-14T07:57:21-05:00
[INFO] Final Memory: 57M/161M
[INFO] ------------------------------------------------------------------------
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (test-check) on project build-failure-analyzer: You have 1 Checkstyle violation. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (test-check) on project build-failure-analyzer: You have 1 Checkstyle violation.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
    at org.jvnet.hudson.maven3.launcher.Maven32Launcher.main(Maven32Launcher.java:132)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchStandard(Launcher.java:330)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:238)
    at jenkins.maven3.agent.Maven32Main.launch(Maven32Main.java:181)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at hudson.maven.Maven3Builder.call(Maven3Builder.java:136)
    at hudson.maven.Maven3Builder.call(Maven3Builder.java:71)
    at hudson.remoting.UserRequest.perform(UserRequest.java:121)
    at hudson.remoting.UserRequest.perform(UserRequest.java:49)
    at hudson.remoting.Request$2.run(Request.java:324)
    at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.maven.plugin.MojoFailureException: You have 1 Checkstyle violation.
    at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:582)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 30 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[JENKINS] Archiving /scratch/jenkins/workspace/plugins/build-failure-analyzer-plugin/pom.xml to com.sonyericsson.jenkins.plugins.bfa/build-failure-analyzer/1.11.1-SNAPSHOT/build-failure-analyzer-1.11.1-SNAPSHOT.pom
Sending artifact delta relative to plugins » build-failure-analyzer-plugin » Build Failure Analyzer #88
Archived 1 artifacts
Archive block size is 32768
Received 0 blocks and 12452 bytes
Compression is 0.0%
Took 0.29 sec
channel stopped
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Sending email to: [email protected] [email protected]
Putting comment on the pull request
Finished: FAILURE

dcoraboeuf · 2015-01-14T16:03:59Z

On last build (https://jenkins.ci.cloudbees.com/job/plugins/job/build-failure-analyzer-plugin/92/console), it looks OK. I have made a correction since then: 5f3e14e

rsandell · 2015-01-14T16:20:55Z

I'll work on the tests a bit later today.

No worries, I won't be able to look at it until earliest tomorrow anyways.

dcoraboeuf · 2015-01-14T16:24:36Z

Another thing, if this pull request is merged back and released, the Wiki page at https://wiki.jenkins-ci.org/display/JENKINS/Build+Failure+Analyzer will have also to be adapted.

rsandell · 2015-01-14T16:29:58Z

Most likely, I hope someone remembers to do that ;) I barely remember to update the changelog when I release :D

dcoraboeuf · 2015-01-14T18:36:43Z

I have tried to create some unit tests (see 4686648, on a separate branch) but I face the following error when running them:

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 500 org.apache.commons.jelly.JellyTagException: jar:file:/Users/damien/.m2/repository/org/jenkins-ci/main/jenkins-core/1.480/jenkins-core-1.480.jar!/lib/layout/layout.jelly:237:26: 
<d:invokeBody> org.apache.commons.jelly.JellyTagException: jar:file:/Users/damien/.m2/repository/org/jenkins-ci/main/jenkins-core/1.480/jenkins-core-1.480.jar!/lib/layout/main-panel.jelly:36:21:
<d:invokeBody> Cannot invoke method isGraphsEnabled() on null object for http://localhost:55465/failure-cause-management/

Does it ring a bell?

dcoraboeuf · 2015-01-14T18:51:52Z

Funny enough, when I run the test on the command line, it's working file. It's only in my IDE (Intellij) where I have this problem. I will go on using the command line right now.

dcoraboeuf · 2015-01-14T19:12:58Z

I've now added 4 unit tests to test different combinations of security accesses. They work when ran locally using the command line (mvn clean verify). Waiting for the Jenkins' feedback.

Damien.

rsandell · 2015-01-15T09:53:03Z

Some types of source code changes needs to have an updated manifest file for the hpi, running the tests from IDEA doesn't generate that metadata, but running mvn package or mvn hpi:run etc. once will generate it and you can normally go back to running from the IDE again.

dcoraboeuf · 2015-01-15T09:55:01Z

Understood. Thanks for the tip.

Configurable anonymous access to the list of failure causes

dcoraboeuf · 2015-01-15T10:36:40Z

Do you know when we could expect a new release containing this enhancement? It's for us to know if we have to wait or if we have to patch our Jenkins in the meantime? We'll use this feature to provide documentation to our different projects.

rsandell · 2015-01-15T11:17:29Z

I think I can cut a release now

Configurable anonymous access to the list of failure causes

ffbede3

Correction of checkstyle issue

5f3e14e

rsandell reviewed Jan 14, 2015
View reviewed changes

Adding the view permission as a safety

03f1894

Creating unit tests for pull request jenkinsci#31 (work in progress)

4686648

Creating unit tests for pull request jenkinsci#31

5742313

rsandell added a commit that referenced this pull request Jan 15, 2015

Merge pull request #31 from dcoraboeuf/master

ae11da7

Configurable anonymous access to the list of failure causes

rsandell merged commit ae11da7 into jenkinsci:master Jan 15, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configurable anonymous access to the list of failure causes #31

Configurable anonymous access to the list of failure causes #31

dcoraboeuf commented Jan 14, 2015

jenkinsadmin commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell Jan 14, 2015

dcoraboeuf Jan 14, 2015

rsandell commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

AnneTheAgile commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell commented Jan 15, 2015

dcoraboeuf commented Jan 15, 2015

dcoraboeuf commented Jan 15, 2015

rsandell commented Jan 15, 2015

Configurable anonymous access to the list of failure causes #31

Configurable anonymous access to the list of failure causes #31

Conversation

dcoraboeuf commented Jan 14, 2015

jenkinsadmin commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell Jan 14, 2015

Choose a reason for hiding this comment

dcoraboeuf Jan 14, 2015

Choose a reason for hiding this comment

rsandell commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

AnneTheAgile commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

dcoraboeuf commented Jan 14, 2015

rsandell commented Jan 15, 2015

dcoraboeuf commented Jan 15, 2015

dcoraboeuf commented Jan 15, 2015

rsandell commented Jan 15, 2015