Merge pull request #44 from DevFactory/release/general-code-quality-f…

…ix-4 General code quality fix-2
jenkinsci · Feb 26, 2016 · 309a8cb · 309a8cb
2 parents 157344e + fcc52b8
commit 309a8cb
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 12 deletions.
diff --git a/src/main/java/com/sonyericsson/jenkins/plugins/bfa/CauseManagement.java b/src/main/java/com/sonyericsson/jenkins/plugins/bfa/CauseManagement.java
@@ -54,7 +54,6 @@
 import java.util.Calendar;
 import java.util.Date;
 import java.util.Map;
-import java.util.logging.Logger;
 
 /**
  * Page for managing the failure causes.
@@ -64,8 +63,6 @@
 @Extension
 public class CauseManagement extends BfaGraphAction {
 
-    private static final Logger logger = Logger.getLogger(CauseManagement.class.getName());
-
     /**
      * Where in the Jenkins name space this action will be.
      *

diff --git a/src/main/java/com/sonyericsson/jenkins/plugins/bfa/graphs/TimeSeriesChart.java b/src/main/java/com/sonyericsson/jenkins/plugins/bfa/graphs/TimeSeriesChart.java
@@ -153,9 +153,7 @@ public int compare(FailureCauseTimeInterval o1, FailureCauseTimeInterval o2) {
 
         plot.setRangeAxis(yAxis);
 
-        JFreeChart chart = new JFreeChart(graphTitle, JFreeChart.DEFAULT_TITLE_FONT, plot, true);
-
-        return chart;
+        return new JFreeChart(graphTitle, JFreeChart.DEFAULT_TITLE_FONT, plot, true);
     }
 
     /**

diff --git a/src/main/java/com/sonyericsson/jenkins/plugins/bfa/model/FailureCauseColumn.java b/src/main/java/com/sonyericsson/jenkins/plugins/bfa/model/FailureCauseColumn.java
@@ -119,8 +119,7 @@ private FailureCauseBuildAction findFailureCauseBuildAction(Job job) {
     if (lastBuild == null) {
       return null;
     }
-    FailureCauseBuildAction action = lastBuild.getAction(FailureCauseBuildAction.class);
-    return action;
+    return lastBuild.getAction(FailureCauseBuildAction.class);
   }
 
 }
diff --git a/src/main/java/com/sonyericsson/jenkins/plugins/bfa/model/dbf/BuildFlowDBF.java b/src/main/java/com/sonyericsson/jenkins/plugins/bfa/model/dbf/BuildFlowDBF.java
@@ -32,7 +32,6 @@
 import java.util.Set;
 import java.util.concurrent.CancellationException;
 import java.util.concurrent.ExecutionException;
-import java.util.logging.Logger;
 
 
 /**
@@ -43,8 +42,6 @@
 @Extension
 public class BuildFlowDBF extends DownstreamBuildFinder {
 
-    private static final Logger logger = Logger.
-            getLogger(BuildFlowDBF.class.getName());
     @Override
     public List<AbstractBuild<?, ?>> getDownstreamBuilds(
             final AbstractBuild build) {

diff --git a/src/main/java/com/sonyericsson/jenkins/plugins/bfa/sod/ScanOnDemandTask.java b/src/main/java/com/sonyericsson/jenkins/plugins/bfa/sod/ScanOnDemandTask.java
@@ -89,7 +89,6 @@ public void run() {
     public void endMatrixBuildScan() throws IOException {
         List<MatrixRun> runs = ((MatrixBuild)build).getRuns();
         List<MatrixRun> runsWithCorrectNumber = new LinkedList<MatrixRun>();
-        int i = 0;
         for (MatrixRun run : runs) {
             if (run.getNumber() == build.getNumber()) {
                 runsWithCorrectNumber.add(run);