[JENKINS-41795] Report event origins #79
Conversation
|
Exposing debug information to end users looks like overkill. Who cares about this IPs? |
| @@ -62,6 +64,10 @@ public Date getTimestamp() { | |||
| return new Date(timestamp); | |||
| } | |||
|
|
|||
| public String getOrigin() { | |||
There was a problem hiding this comment.
@NonNull because the event will substitute ?
| @@ -1 +1,2 @@ | |||
| blurb=Branch event at {0,time} on {0,date} | |||
| origin=Origin: {0} | |||
There was a problem hiding this comment.
Will this show Origin: ? if the origin is unknown?
|
@KostyaSha said:
When the user is trying to determine why they have strange extra builds being triggered the IP address of the origin of the requests is vital. There is no value in hiding the information from users as it will be in the logs that anyone with Item/READ can access anyway, and we cannot hide the origin in the logs from non-admins (plus the origin is expected to normally be the SCM system - given that the SCM links will be pointing to that system, its IP address is not exactly top secret) The origin is only available as a tool-tip so not exactly in your face either |
Downstream of jenkinsci/scm-api-plugin#27
See JENKINS-41795
Reports the origin of events, the event logs will now look something like:
And the tooltip for a branch event will include the origin if known:
@reviewbybees