[JENKINS-74879] Use strikethrough on merged pull request name column #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.jenkins.io/browse/JENKINS-74879 reports that the strikethrough text is no longer previously displayed when a pull request has been merged or closed. The strikethrough text is a nice visual indicator that the job is no longer active. Let's bring it back so that the visual hint is still there for users. The strikethrough text is displayed on the job page, but not in the table of jobs for each pull request or branch. Change was originally introduced when pull request titles were enabled by default in the column name. Refer to: * jenkinsci#476 Assumed that it is better to drop the jenkins-table__link formatting in the plugin rather than adjust the CSS definion in Jenkins core. That CSS definition has been in place in Jenkins core since Sep 2022 and likely would have unexpected side effects if changed in core. Refer to: * jenkinsci/jenkins#6248 Testing done: * Confirmed that the link has strikethrough text with this change. * Confirmed that the non-striketrhrough link still looks good
|
probably unrelated - but disabled jobs don't look right in dark theme (the status "logo" is hardly visible) https://issues.jenkins.io/browse/JENKINS-75096
|
Should be fixed in the next weekly - jenkinsci/jenkins#10106 |
janfaracik
approved these changes
Jan 7, 2025
jglick
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JENKINS-74879] Use strikethrough on merged pull request name column
JENKINS-74879 reports that the strikethrough text is no longer displayed when a pull request has been merged or closed. The strikethrough text is a nice visual indicator that the job is no longer active. Let's bring it back so that the visual hint is still there for users.
The strikethrough text is displayed on the job page, but not in the table of jobs for each pull request or branch.
Change was originally introduced when pull request titles were enabled by default in the column name. Refer to:
Assumed that it is better to drop the jenkins-table__link formatting in the plugin rather than adjust the CSS definion in Jenkins core. That CSS definition has been in place in Jenkins core since Sep 2022 and likely would have unexpected side effects if changed in core. Refer to:
Before this change
After this change
Testing done
Submitter checklist