remove lib.form.hetero-list.hetero-list #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car-roll
changed the title
car-roll
commented
Nov 7, 2023
| @@ -68,7 +68,7 @@ | |||
| <revision>2</revision> | |||
| <changelist>999999-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | |||
| <jenkins.version>2.387.3</jenkins.version> | |||
| <jenkins.version>2.426</jenkins.version> | |||
There was a problem hiding this comment.
change was introduced in 2.422, chose the (soon-to-be) next LTS
car-roll
changed the title
raul-arabaolaza
approved these changes
Nov 8, 2023
rsandell
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/jenkins#8418 (comment)
hetero-listadjunct was removed in jenkinsci/jenkins#8418If this adjunct gets called, a large stack trace error should appear in the logs.
Testing done
adjunct resides in
branchSourceSelector.jelly, which is called byconfigure-branches.jelly, thenconfigure-entries.jellyfromMultibranchProject. Tested under a local instance using a github multibranch folderbut have not been able to extract any errorsand was able to generate an error. This PR + jenkinsci/scm-api-plugin#228 removes the errorSubmitter checklist