Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin parent POM #180

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Update plugin parent POM #180

merged 2 commits into from
Apr 24, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 23, 2022

I have been attempting to run PCT tests in jenkinsci/bom against Java 17 and newer versions of PCT, and this plugin is running into failures because its parent POM is too old. This PR updates the parent POM to the latest build toolchain from jenkinsci/analysis-pom-plugin#446 to facilitate Java 17 compatibility testing and PCT updates in jenkinsci/bom.

@basil
Copy link
Member Author

basil commented Apr 23, 2022

As in jenkinsci/checks-api-plugin#163 (comment), you cannot have your CI build set up to use Java 8 but your Maven build set up to use Checkstyle 10 (which requires Java 11).

@basil
Copy link
Member Author

basil commented Apr 23, 2022

jenkinsci/analysis-pom-plugin#420 should be reverted.

@uhafner
Copy link
Member

uhafner commented Apr 24, 2022

Actually this plugin is deprecated for almost a year now. I'm not sure if it makes sense to spent any effort here anymore. It has been superseded by https://github.com/jenkinsci/bootstrap5-api-plugin

@basil
Copy link
Member Author

basil commented Apr 24, 2022

Then finish jenkinsci/bom#571.

This commit will not be tested in the CI build for this PR, since I do
not have write access to this repository.
@basil
Copy link
Member Author

basil commented Apr 24, 2022

Java 8 removed from Jenkinsfile in commit f1dd03f. This commit will not be tested in the CI build for this PR, since I do not have write access to this repository.

@uhafner
Copy link
Member

uhafner commented Apr 24, 2022

Then finish jenkinsci/bom#571.

Well, I tried my best but it seems that we still have a deadlock in the JUnit plugin. Hopefully, it will be resolved if the UI tests will be merged. My changes (that are in production in all other plugins) are one year old now.

@uhafner uhafner merged commit 7a2709e into jenkinsci:master Apr 24, 2022
@basil basil deleted the pom branch April 24, 2022 13:11
@basil
Copy link
Member Author

basil commented Apr 24, 2022

That is of concern to me, because if we can't do UI testing of modern JavaScripts frameworks from plugins, then we can't do it in core. And if we can't do it in core, we can't refactor and modernize the UI with confidence and without constant fear of regression. So this is a big concern to me. I have not been following the other thread too closely, but could you help me understand what are the main reasons this effort is blocked? Is there some underlying infrastructure I could help provide to move this along? This is the wrong forum, but feel free to let me know if you would be willing to discuss this somewhere else.

@uhafner
Copy link
Member

uhafner commented Apr 24, 2022

This is a long story... I'll send you an email (but not today, it's too late now... )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants