Pin htmlpublisher 1.36 for older lines

[MarkEWaite]

Pin htmlpublisher 1.36 for older lines

Prevent test failure in the declarative Pipeline plugin when it attempts to load htmlpublisher 1.37 on Jenkins 2.479.x and earlier.

Tests fail with the commands:

$ LINE=2.479.x PLUGINS=pipeline-model-definition TEST=InjectedTest bash local-test.sh
$ LINE=2.462.x PLUGINS=pipeline-model-definition TEST=InjectedTest bash local-test.sh
$ LINE=2.452.x PLUGINS=pipeline-model-definition TEST=InjectedTest bash local-test.sh

Failure message is:

> Failed to load: HTML Publisher plugin (htmlpublisher 1.37)
>  - Update required: Matrix Project Plugin (matrix-project 832.va_66e270d2946) 
>    to be updated to 838.v4d7b_7b_f9b_d4b_ or higher

The matrix project release 839.vff91cd7e3a_b_2 is already defined in those older release lines but that definition does not seem to be honored by the pipeline-model-definition test configuration.

Testing done

Confirmed that the failure cases all pass with this change.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

but that definition does not seem to be honored by the pipeline-model-definition test configuration

Because it is an optional dependency of git-plugin and isn't upgraded by PCT—a long-standing issue. This is what I was alluding to in the known issues part of #3158. Another workaround is to add the optional dependency in test scope in the consumer (in this case, pipeline-model-definition)—something which feels (and is) wrong/unnecessary, but does chase away the issue. Pinning as you did here works, but isn't an option on the weekly line (only older lines), and sometimes this problem occurs there. Perhaps now that you have faced this head-on you might be interested in documenting it.

[MarkEWaite]

Thanks! I've attempted some documentation at:

• Describe 2 known issues and link to example pull requests #3980