Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.jenkins-ci.main:jenkins-war to v2.484 #3912

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 5, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jenkins-ci.main:jenkins-war 2.483 -> 2.484 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner November 5, 2024 18:44
@renovate renovate bot added dependencies Pull requests that update a dependency file weekly-test labels Nov 5, 2024
@renovate renovate bot enabled auto-merge (rebase) November 5, 2024 18:44
@MarkEWaite
Copy link
Contributor

@jglick there is a test failure in the jacoco plugin when running in the plugin BOM with Jenkins 2.484. I see the failure with the command line:

PLUGINS=jacoco LINE=weekly bash local-test.sh

One of the failure messages is:

[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.436 s <<< FAILURE! -- in hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest
[ERROR] hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest.testGetPercentWithBuildAndAction -- Time elapsed: 1.242 s <<< ERROR!
java.lang.IllegalStateException: Found no instances of hudson.model.Job$BuildNumberAssigner registered
        at hudson.ExtensionList.lookupFirst(ExtensionList.java:482)
        at hudson.model.Job.assignBuildNumber(Job.java:345)
        at hudson.model.Run.<init>(Run.java:324)
        at hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest$MyRun.<init>(BranchCoverageColumnTest.java:104)
        at hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest$MyJob.newBuild(BranchCoverageColumnTest.java:97)
        at hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest$1.getLastSuccessfulBuild(BranchCoverageColumnTest.java:49)
        at hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest$1.getLastSuccessfulBuild(BranchCoverageColumnTest.java:42)
        at hudson.plugins.jacococoveragecolumn.AbstractJaCoCoCoverageColumn.hasCoverage(AbstractJaCoCoCoverageColumn.java:40)
        at hudson.plugins.jacococoveragecolumn.AbstractJaCoCoCoverageColumn.getPercent(AbstractJaCoCoCoverageColumn.java:48)
        at hudson.plugins.jacococoveragecolumn.BranchCoverageColumnTest.testGetPercentWithBuildAndAction(BranchCoverageColumnTest.java:64)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)

Could you investigate further?

@jglick
Copy link
Member

jglick commented Nov 5, 2024

@MarkEWaite I already fixed that as jenkinsci/jacoco-plugin#291 but the plugin maintainer has not released it.

@basil
Copy link
Member

basil commented Nov 5, 2024

Then jenkinsci/jenkins#9846 should have been marked as on-hold pending either the release of jenkinsci/jacoco-plugin#291 or the exclusion of this test from jenkinsci/bom.

Copy link
Contributor Author

renovate bot commented Nov 5, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@basil basil disabled auto-merge November 6, 2024 20:41
@basil basil enabled auto-merge (squash) November 6, 2024 20:41
@basil basil merged commit c7c8678 into master Nov 6, 2024
210 of 211 checks passed
@basil basil deleted the renovate/org.jenkins-ci.main-jenkins-war-2.x branch November 6, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file weekly-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants