Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3539 and #3537 #3840

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fixes #3539 and #3537 #3840

merged 2 commits into from
Oct 25, 2024

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Oct 25, 2024 •
edited by basil
Loading

Now that PR-3838 has merged, reverting the excludes for BFA.

Testing done

ran tests locally for all 4 lines

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fixes #3539
Fixes #3537

@darinpope
Fixes jenkinsci#3539 and jenkinsci#3537
b14b208 
Now that PR-3838 has merged, reverting the excludes for BFA.
@darinpope darinpope requested a review from a team as a code owner October 25, 2024 19:01
@darinpope darinpope added the full-test Test all LTS lines in this PR and do not halt upon first error. label Oct 25, 2024
basil
basil approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) October 25, 2024 19:16
@darinpope
adding pull 181 back in
056b492 
it appears the fix doesn't cover jenkinsci#3537. Putting this back in to see if jenkinsci#3539 works ok.
@MarkEWaite MarkEWaite merged commit 2ad51cc into jenkinsci:master Oct 25, 2024
792 of 793 checks passed
@darinpope darinpope deleted the 3539-and-3537 branch October 25, 2024 22:42
@darinpope
Copy link
Contributor Author

As noted in the re-opened #3537 , this PR only fixes #3539. I should have done each issue as a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@basil basil basil approved these changes

Assignees
No one assigned
Labels
full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove build-failure-analyzer-plugin#181 workaround Remove build-failure-analyzer-plugin#182 workaround
3 participants
@darinpope @basil @MarkEWaite