Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplify scripts by removing issueId parameter #3795

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

darinpope
Copy link
Contributor

After a bit more digging, I found that it wasn't necessary to pass in the GitHub issue id to some of the scripts. This should make it even easier to follow the daily (primarily Friday) task list.

The catch is the math to get the issue id is we are looking for an issue that has a release label (set in the create script). We need to make sure that there is never more than one open issue that has a release label. I did limit the return to just 1, but if there are multiple, it's going to grab the most current, even if that's not the one you want. This probably isn't a huge deal because only one person should be doing the release, so that's why I didn't go overboard with protections.

Testing done

Ran scripts to verify.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

After a bit more digging, I found that it wasn't necessary to pass in the GitHub issue id to some of the scripts. This should make it even easier to follow the daily (primarily Friday) task list.

The catch is the math to get the issue id is we are looking for an issue that has a `release` label (set in the create script). We need to make sure that there is never more than one open issue that has a `release` label. I did limit the return to just 1, but if there are multiple, it's going to grab the most current, even if that's not the one you want.  This probably isn't a huge deal because only one person should be doing the release, so that's why I didn't go overboard with protections.
@darinpope darinpope requested a review from a team as a code owner October 17, 2024 18:26
@darinpope darinpope merged commit 40b33b7 into jenkinsci:master Oct 17, 2024
5 checks passed
@darinpope darinpope deleted the derive-issue-id branch October 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant