Further simplify scripts by removing issueId parameter #3795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit more digging, I found that it wasn't necessary to pass in the GitHub issue id to some of the scripts. This should make it even easier to follow the daily (primarily Friday) task list.
The catch is the math to get the issue id is we are looking for an issue that has a
release
label (set in the create script). We need to make sure that there is never more than one open issue that has arelease
label. I did limit the return to just 1, but if there are multiple, it's going to grab the most current, even if that's not the one you want. This probably isn't a huge deal because only one person should be doing the release, so that's why I didn't go overboard with protections.Testing done
Ran scripts to verify.
Submitter checklist